Warrior Professions
When levelling up, pick two gathering professions. That will get you a couple hundred gold by level 40. I chose mining and skinning, but herbalism and skinning are fine too. Remember that herbalism and mining share the same mini-map, so you probably don't want both.
If you feel like eventually taking up a real tradeskill, I'd say engineering, alchemy or smithing. I chose smithing. Smithing is really expensive to level up, but, in theory, can eventually make you a nice profit, and you can make your own armor and weapons on the way. Engineering and alchemy give you a lot of toys to make you an even better warrior.
In the end, it depends on what you find fun. If you want the convenience of making your own potions, alchemy might be the right choice. If you like having lots of weird toys for PvP, engineering. If you want an old school profession that complements your class needs, take blacksmithing.
